Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COmmenting out Sindarin for now because it blocks a complex PR. #927

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

Ducasse
Copy link
Contributor

@Ducasse Ducasse commented Dec 24, 2024

No description provided.

@Ducasse Ducasse merged commit b9d54ab into pharo-spec:Pharo13 Dec 24, 2024
1 of 2 checks passed
@StevenCostiou
Copy link
Member

Any idea why it blocks the other PR?
Can you provide the link of that other PR in this conversation as a trace?

@StevenCostiou
Copy link
Member

Is that one pharo-project/pharo#17553 ?

@StevenCostiou
Copy link
Member

By the way that might be the opportunity to rename "ScriptableDebugger" into "Sindarin".
That will be a story for next year.

@Ducasse
Copy link
Contributor Author

Ducasse commented Dec 24, 2024

Hi steven
This is two days that I'm trying to understand the problem and I have the impression that the code I changed is in Sindarin but the build loads from NewTools.
So I would like to decompose the problem because once the other PR passes it will be simple to fix.

@Ducasse
Copy link
Contributor Author

Ducasse commented Dec 24, 2024

@StevenCostiou
Copy link
Member

These all look like extension methods of the original AST* classes.
Are they correctly "migrated" as extensions to the new OC* classes by the refactoring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants