Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue while trying to display file setting items #736

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Fix issue while trying to display file setting items #736

merged 5 commits into from
Apr 4, 2024

Conversation

hernanmd
Copy link
Member

@hernanmd hernanmd commented Apr 4, 2024 •
edited
Loading

This PR fixes various problems with the setting browser:

  • Add two setting wrappers for selection of directory and files in the new settings browser.
  • Fix layout of settings pages to avoid unnecessary scroll bars.
  • Better layout and colors.
  • Add missing method to display file reference names in the setting browser.
  • Remove duplicated default: in Playground setting.
  • Fix opening of Color Picker

Hernán Morales Durand added 2 commits April 4, 2024 19:52
Fix issue while trying to display file setting items.
3220900 
Add two setting wrappers for selection of directory and files in the new settings browser.
Fix layout of settings pages to avoid unnecessary scroll bars.
Better layout and colors.
Fix TraitedClass additions
8a9f453
@hernanmd hernanmd self-assigned this Apr 4, 2024
@hernanmd hernanmd added bug Something isn't working enhancement New feature or request labels Apr 4, 2024
@hernanmd hernanmd requested a review from Ducasse April 4, 2024 18:53
@hernanmd
Copy link
Member Author

hernanmd commented Apr 4, 2024

Same failing tests as in other previous PR (#733) so shouldn't be related

testCheckExistenceOfNonExistingFileDoesNotThrowException
testFlushLargeMessageOtherEndClosed
testSlotOrVarLinksRemainAfterMethodModificationForObject

@Ducasse Ducasse merged commit d50d35c into pharo-spec:Pharo12 Apr 4, 2024
1 of 2 checks passed
@hernanmd hernanmd mentioned this pull request Apr 5, 2024
Closed
@hernanmd hernanmd deleted the fix_new_browser_file_locator branch June 20, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ducasse Ducasse Awaiting requested review from Ducasse

Assignees

@hernanmd hernanmd

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hernanmd @Ducasse