Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As they can cause lots of unexpected concurrency issues.
They are a nice idea but they need more work.
See for example pharo-project/pharo#16311
More importantly, this breaks profiling completely, and has unexpected results that even experienced users will have difficulties reasoning about.
Here is an example of the potential performance issues we could have with a small example.
The async do it executes in low priority, which contends against the UI thread, giving overheads of at least ~4x in the following silly example.
And we have observed last week even worse cases and deadlocks.
So leaving a button that can deadlock your image is not very nice unless it has a dead head :)
Normal
High