-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Dialog: Add dynamic preview #682
Conversation
…xtension or a FileReference. - Add GIF previewer
src/NewTools-FileBrowser/StFileBrowserTextBasedContentPreviewer.class.st
Outdated
Show resolved
Hide resolved
Fix typos.
Adjust window size and position.
@hernanmd you have
|
Hi @jecisc, I tried to reproduce locally the failing Pharo-Integration tests but even after fixing a Sindarin loading error, the tests ( Metacello new
baseline: 'NewTools';
repository: 'github://hernanmd/NewTools:add_dynamic_preview/src';
load. I also tried running through smalltalkCI but it was worst as Spec changes were missing: bin/smalltalkci --headful -s Pharo64-12 ../git-repositories/NewTools/.smalltalk.ston Do you know what else to try? |
…ng "testNoUnusedClassVariablesLeft" to fail.
Ok, I managed to load the PR in the TravisCI.image and discovered lot of methods were missing, causing unreferenced variables and obsolete classes. I tried to rename the classes but still the Obsolete are introduced in the Pharo Integration CI job. So this could mean code importing bug? |
Finally. Errors were related to the
|
Tx |
This PR adds the following features to File Dialog support: