Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test debugger does not log exceptions twice when opened #643

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Test debugger does not log exceptions twice when opened #643

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d7070c
Add test to check when the log debugger stack to file setting is fals…
Dec 8, 2023
228d415
Remove non-sense assertion
Dec 8, 2023
26ccb5c
Merge branch 'pharo-spec:Pharo12' into add_debugger_test_log_twice_fix
hernanmd Jan 19, 2024
ee5d8e8
Update to ensure set back the debuggingStackToFile setting if test fa…
Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/NewTools-Debugger-Tests/StDebuggerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,30 @@ StDebuggerTest >> testDebuggerApplication [
identicalTo: StDebugger currentApplication
]

{ #category : 'tests - session' }
StDebuggerTest >> testDebuggerDoesNotLogStackToFileSetting [

| logFileRef debuggingStackToFile |

logFileRef := Smalltalk logFileName asFileReference.
logFileRef ensureDelete.
self deny: logFileRef exists.
debuggingStackToFile := session class logDebuggerStackToFile.
[
debugger := StTestDebuggerProvider new debuggerWithDNUContext.
session := debugger session.
session class logDebuggerStackToFile: false.
debugger
application: debugger class currentApplication;
initialize;
open.

self
assert: logFileRef exists not
description: 'It tests that when the log debugger stack to file setting is false, a Pharo log file is not created when requesting a debugger' ]
ensure: [ session class logDebuggerStackToFile: debuggingStackToFile ]
]

{ #category : 'tests - code pane' }
StDebuggerTest >> testDiscardCodeChangesFor [
| firstContext lastContext |
Expand Down
Loading