Move methods from Manifest #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple methods are defined in the Manifest package but are used only for the critics UI. I propose to move them to the UI package. I also used packages instead of categories and updated a call to a deprecated method.
jecisc
added a commit
to jecisc/pharo
that referenced
this pull request
Oct 30, 2023
This change moves the display methods of critics from Manifest-Core to the UI packages. Since the UI packages are not in Pharo we need to wait for PR: pharo-spec/NewTools#606 I'm also fixing a deprecation
MarcusDenker
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple methods are defined in the Manifest package but are used only for the critics UI. I propose to move them to the UI package.
I also used packages instead of categories and updated a call to a deprecated method.