Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack coloring to the debugger #521

Merged
merged 7 commits into from
May 29, 2023
Merged

Add stack coloring to the debugger #521

merged 7 commits into from
May 29, 2023

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented May 11, 2023

This PR add some stack coloring to the debugger.

Now the stack has 3 different text colors:

  • One when the context of a stack element is from the same class than the selected context
  • One when the context of the stack element is from the same package than the selected context
  • And the default text color otherwise

This is especially useful when debugging some pattern such as visitors or composites...

image

image

I wanted to add an info popup to describe the feature but I didn't find a way to display text in Spec, just strings.

THIS REQUIRES: pharo-project/pharo#13693

Copy link
Member

@StevenCostiou StevenCostiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are ok.
There are tests failing because of the changes though.

@jecisc
Copy link
Member Author

jecisc commented May 11, 2023

This is because the Pharo PR has not been reviewed and integrated yet. I’ll restart it when it will be the case.

@StevenCostiou
Copy link
Member

Would it be possible to have a setting to (de)activate the coloring?
I guess the next step (after that PR) would be to have a system to custsomize the coloring? :P

@jecisc
Copy link
Member Author

jecisc commented May 11, 2023

I can check to do that when I'll have the time

For the customization, I made it part of the theme. So user can create their own theme. We can also see to improve the default values Pharo's theme if someone has knowledge on color palette.

Another idea would be to have in the setting the possibility to customize all colors of the theme but this is out of the scope of this feature :)

@StevenCostiou
Copy link
Member

For the customization, I meant customizing what to highlight and under what conditions.
From there why not choosing the color from their application or directly in their customization.

@jecisc
Copy link
Member Author

jecisc commented May 26, 2023

Would it be possible to have a setting to (de)activate the coloring? I guess the next step (after that PR) would be to have a system to custsomize the coloring? :P

Done!

Copy link
Member

@StevenCostiou StevenCostiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cyril!
A few comments, but seems good otherwise.

@Ducasse
Copy link
Contributor

Ducasse commented May 29, 2023

Cool. I just mentioned to Cyril that we should pay attention with too pale (or not even intense colors) because of color blind people. There are software that simulate what the color blind people can see and this is nice to try. We did it for the mooc template.

@Ducasse Ducasse merged commit 06c1e59 into Pharo12 May 29, 2023
@guillep guillep deleted the add-stack-coloring branch February 9, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants