-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stack coloring to the debugger #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are ok.
There are tests failing because of the changes though.
This is because the Pharo PR has not been reviewed and integrated yet. I’ll restart it when it will be the case. |
Would it be possible to have a setting to (de)activate the coloring? |
I can check to do that when I'll have the time For the customization, I made it part of the theme. So user can create their own theme. We can also see to improve the default values Pharo's theme if someone has knowledge on color palette. Another idea would be to have in the setting the possibility to customize all colors of the theme but this is out of the scope of this feature :) |
For the customization, I meant customizing what to highlight and under what conditions. |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Cyril!
A few comments, but seems good otherwise.
Cool. I just mentioned to Cyril that we should pay attention with too pale (or not even intense colors) because of color blind people. There are software that simulate what the color blind people can see and this is nice to try. We did it for the mooc template. |
This PR add some stack coloring to the debugger.
Now the stack has 3 different text colors:
This is especially useful when debugging some pattern such as visitors or composites...
I wanted to add an info popup to describe the feature but I didn't find a way to display text in Spec, just strings.
THIS REQUIRES: pharo-project/pharo#13693