Fix DNU when recompiling block with dead home #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choose endPC as home pc in that case. Check that the home is recompiled and the stack does not move
|
I experimented with your branch because I wanted to check some things and I found a bug: If you recompile the method with the dead block, it will work the first time but not if you attempt to recompile it a second time in the same debugger. |
adri09070
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
The only reason I haven't approved the changes yet is that I'm not sure that the tests actually test the right things, and I wonder if it could not lead to another (minor) bug in the debugger inspector update.
Still, it fixes an annoying bug, so I think we can merge it and see if it actually leads to other bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose endPC as home pc in that case.
Check that the home is recompiled and the stack does not move
Depends on pharo-project/pharo#13592