Skip to content

Commit

Permalink
Change default in logErrorsToTranscript setting, so we do not pollute…
Browse files Browse the repository at this point in the history
… output by default.

Also execute the Example tests without logging to transcript so the CI isn't polluted.
  • Loading branch information
Hernán Morales Durand committed Jan 21, 2024
1 parent 79630c0 commit 1e9615f
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
15 changes: 15 additions & 0 deletions src/NewTools-Finder-Tests/StFinderExampleTest.class.st
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
Class {
#name : 'StFinderExampleTest',
#superclass : 'StFinderTest',
#instVars : [
'previousLogSetting'
],
#category : 'NewTools-Finder-Tests-Core',
#package : 'NewTools-Finder-Tests',
#tag : 'Core'
Expand All @@ -10,11 +13,23 @@ Class {
StFinderExampleTest >> setUp [

super setUp.

"Avoid polluting the CI output during tests"
previousLogSetting := StFinderSettings logErrorsToTranscript.
StFinderSettings logErrorsToTranscript: false.

presenterModel currentSearch: StFinderExampleSearch new.
self openInstance.

]

{ #category : 'running' }
StFinderExampleTest >> tearDown [

StFinderSettings logErrorsToTranscript: previousLogSetting.
super tearDown.
]

{ #category : 'running' }
StFinderExampleTest >> testConcatenationSearch [

Expand Down
4 changes: 2 additions & 2 deletions src/NewTools-Finder/StFinderSettings.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ StFinderSettings class >> logErrorsToTranscript [
"Modified by settings Finder: self classSide >> #logErrorsToTranscriptOn:"

^ LogErrorsToTranscript
ifNil: [ LogErrorsToTranscript := true ]
ifNil: [ LogErrorsToTranscript := false ]
]

{ #category : 'system settings' }
Expand All @@ -158,7 +158,7 @@ StFinderSettings class >> logErrorsToTranscriptOn: aBuilder [
<systemsettings>
(aBuilder setting: #logErrorsToTranscript)
parent: #finder;
default: true;
default: false;
label: 'Log errors to Transcript';
description: 'Log evaluation errors in the examples search to the Transcript';
target: self
Expand Down

0 comments on commit 1e9615f

Please sign in to comment.