Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)Moved ProfilerUI package #15797

Merged
merged 1 commit into from
Dec 19, 2023
Merged

(Re)Moved ProfilerUI package #15797

merged 1 commit into from
Dec 19, 2023

Conversation

JanBliznicenko
Copy link
Contributor

@JanBliznicenko JanBliznicenko commented Dec 14, 2023

Removed ProfilerUI package in order to move it to the NewTools repository. Part of efforts towards resolving issue #15795, alternative to #15792.

@JanBliznicenko JanBliznicenko changed the title Removed ProfilerUI package (Re)Moved ProfilerUI package Dec 14, 2023
@JanBliznicenko JanBliznicenko marked this pull request as ready for review December 14, 2023 23:08
@jecisc
Copy link
Member

jecisc commented Dec 19, 2023

Hi @JanBliznicenko

Can you remind me the order of the operations to do for this change? Should we merge this one?

@JanBliznicenko
Copy link
Contributor Author

JanBliznicenko commented Dec 19, 2023

Hi @JanBliznicenko

Can you remind me the order of the operations to do for this change? Should we merge this one?

Yes, this one is the one to merge now.

  1. Accept (Re)Moved Profile It command pharo-spec/Spec#1491
  2. Accept (Re)Moved ProfilerUI package #15797
  3. Wait for new pharo image build to be done
  4. Re-run CI of Moved ProfilerUI here pharo-spec/NewTools#648
  5. Accept Moved ProfilerUI here pharo-spec/NewTools#648 (if CI is green)

@jecisc jecisc merged commit 6691b1b into pharo-project:Pharo12 Dec 19, 2023
3 checks passed
@guillep
Copy link
Member

guillep commented Feb 1, 2024

Hi @JanBliznicenko the latest images do not yet have the profiler back.
Is there something missing here? I urgently need the profiler :)

@guillep
Copy link
Member

guillep commented Feb 1, 2024

Ok, I saw that it got lost seemingly in a merge. I've added it back here: pharo-spec/NewTools#680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants