Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeCritics displays rationale with method syntax hightlight #16290

Closed
Ducasse opened this issue Mar 12, 2024 · 2 comments · Fixed by pharo-spec/NewTools#727
Closed

CodeCritics displays rationale with method syntax hightlight #16290

Ducasse opened this issue Mar 12, 2024 · 2 comments · Fixed by pharo-spec/NewTools#727
Labels
To fix before release Issure to fix before the upcoming Pharo release

Comments

@Ducasse
Copy link
Member

Ducasse commented Mar 12, 2024

and it should be plain text.
@Ducasse Ducasse added the To fix before release Issure to fix before the upcoming Pharo release label Mar 12, 2024
@Ducasse
Copy link
Member Author

Ducasse commented Mar 12, 2024

Capture 2024-03-12 at 11 37 09

@demarey
Copy link
Contributor

demarey commented Mar 19, 2024

It should only be plain text when no critic is selected in the right pane but should be hightlighted otherwise

@demarey demarey mentioned this issue Mar 22, 2024
Merged
demarey added a commit to demarey/NewTools that referenced this issue Mar 22, 2024
@demarey
enable / disable syntax highlight in code presenter of critics browser.
a93f43c 
Fixes pharo-project/pharo#16290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
To fix before release Issure to fix before the upcoming Pharo release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable / disable syntax highlight in code presenter of critics browser. demarey/NewTools
2 participants
@Ducasse @demarey