Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1995 Update to add Sophie as Author and Stefan's R in Pharma presentation. #2082

Merged
merged 9 commits into from
Sep 8, 2023
Merged

#1995 Update to add Sophie as Author and Stefan's R in Pharma presentation. #2082

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4889151
#1995 Update to add Sophie as Autor and Stefan's R in Pharma presenta…
manciniedoardo Sep 1, 2023
156b63a
#1995 Chore: roxygen
manciniedoardo Sep 5, 2023
c4131dd
#1995 updates following review
manciniedoardo Sep 6, 2023
4b5e16f
#1995 chore:spellcheck and roxygen
manciniedoardo Sep 6, 2023
60fd35e
Merge branch 'devel' into 1995_prerelease_012@devel
manciniedoardo Sep 6, 2023
c57a01b
Merge branch 'devel' into 1995_prerelease_012@devel
bms63 Sep 7, 2023
ba5a436
#1995 updates to readme with release schedule and 1.0.
manciniedoardo Sep 8, 2023
7e9c8f9
Merge branch '1995_prerelease_012@devel' of github.com:pharmaverse/ad…
manciniedoardo Sep 8, 2023
2559c02
grammar fix in readme
zdz2101 Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,12 @@ Authors@R: c(
person("Edoardo", "Mancini", role = "aut"),
person("Sadchla", "Mascary", role = "aut"),
person("Gordon", "Miller", role = "aut"),
person("Sophie", "Shapcott", role = "aut"),
person("Eric", "Simms", role = "aut"),
person("Stefan", "Thoma", role = "aut"),
person("Kangjie", "Zhang", role = "aut"),
person("Zelos", "Zhu", role = "aut"),
person("Kamila", "Duniec", role = "ctb"),
person("G", "Gayatri", role = "ctb"),
person("Declan", "Hodges", role = "ctb"),
person("Robin", "Koeger", role = "ctb"),
person("Pooja", "Kumari", role = "ctb"),
person("Shan", "Lee", role = "ctb"),
person("Thomas", "Neitmann", role = "ctb"),
person("F. Hoffmann-La Roche AG", role = c("cph", "fnd")),
person("GlaxoSmithKline LLC", role = c("cph", "fnd"))
Expand Down
29 changes: 18 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@ Phases:
* Phase 2 release is extension packages, e.g. [{admiralonco}](https://pharmaverse.github.io/admiralonco/main/), [{admiralophtha}](https://pharmaverse.github.io/admiralophtha/main/), [{admiralvaccine}](https://pharmaverse.github.io/admiralvaccine/main/)


|Release Schedule | Phase 1- Date and Packages | Phase 2- Date and Packages |
|---------------- | -------------------------- | -------------------------- |
| Q3-2023 | September 4th | September 11th |
| | [{admiraldev}](https://pharmaverse.github.io/admiraldev/main/) | [{admiralonco}](https://pharmaverse.github.io/admiralonco/main/) |
| | {pharmaversesdtm} | [{admiralophtha}](https://pharmaverse.github.io/admiralophtha/main/) |
| | [{admiral}](https://pharmaverse.github.io/admiral/main/) | [{admiralvaccine}](https://pharmaverse.github.io/admiralvaccine/main/) |
| Q4-2023 | December 4th | December 11th |
| | [{admiraldev}](https://pharmaverse.github.io/admiraldev/main/) | [{admiralonco}](https://pharmaverse.github.io/admiralonco/main/) |
| | {pharmaversesdtm} | [{admiralophtha}](https://pharmaverse.github.io/admiralophtha/main/) |
| | [{admiral}](https://pharmaverse.github.io/admiral/main/) | [{admiralvaccine}](https://pharmaverse.github.io/admiralvaccine/main/) |
|Release Schedule | Phase 1- Date and Packages | Phase 2- Date and Packages | Phase 3- Date and Packages |
|---------------- | -------------------------- | -------------------------- | -------------------------- |
| Q3-2023 | September 4th | September 11th | September 18th |
| | [{pharmaversesdtm}](https://pharmaverse.github.io/pharmaversesdtm/main/) | [{admiraldev}](https://pharmaverse.github.io/admiraldev/main/) | [{admiralonco}](https://pharmaverse.github.io/admiralonco/main/) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this to December release and add the next one for Q1 2024. That way it isn't stale

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but after december next release may be Q2 2024?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a rule stated - releases are targeted for the first Monday of the last month of each quarter.

Does the Q1 2024 not align?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it doesn’t if we move to a bi-yearly release schedule following 1.0. So maybe we can add something about that instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think then we should re-work this section stating our new goals and a new rule for a bi-annual release.

Still include a blurb saying we have a release in Q4-2024 and shifting from 4 releases to 2 releases. Next release is expected in June???

Also - can you link the pharmaversesdtm website? I think that is a nice thing to show off!?!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manciniedoardo , @bms63 , do you think it is realistic that we release version 1.0 in Q4-2024?

I think at the moment we do not have a clear idea what we need to change for a stable version. (I have just started this week working on an overview.) Discussing, agreeing on, and implementing these changes this year seems quite challenging to me.

Thus I would just announce a Q1-2024 release.

Copy link
Collaborator Author

@manciniedoardo manciniedoardo Sep 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see discussion here around 1.0 - we do wish to commit to it but can moderate the language (e.g. mature rather than stable).

| | | [{admiral}](https://pharmaverse.github.io/admiral/main/) | [{admiralophtha}](https://pharmaverse.github.io/admiralophtha/main/) |
| | | | [{admiralvaccine}](https://pharmaverse.github.io/admiralvaccine/main/) |
| Q4-2023 | December 4th | December 11th | |
| | [{pharmaversesdtm}](https://pharmaverse.github.io/pharmaversesdtm/main/) | [{admiralonco}](https://pharmaverse.github.io/admiralonco/main/) | |
| | [{admiraldev}](https://pharmaverse.github.io/admiraldev/main/) | [{admiralophtha}](https://pharmaverse.github.io/admiralophtha/main/) | |
| | [{admiral}](https://pharmaverse.github.io/admiral/main/) | | |

## Main Goal

Expand Down Expand Up @@ -152,8 +152,15 @@ that all our developers and contributors must follow, so that all our code has a
* Please see the [Contribution Model](https://pharmaverse.github.io/admiral/cran-release/articles/contribution_model.html) for how to get involved with making contributions
* Please see [FAQ: R and Package Versions](https://pharmaverse.github.io/admiral/cran-release/articles/faq.html#why-do-we-use-a-certain-r-version-and-package-versions-for-development) for why we develop with certain R and package versions.

## Pharmaverse Blog
If you are interested in R and Clinical Reporting, then visit the [pharmaverse blog](https://pharmaverse.github.io/blog/). This contains regular, bite-sized posts showcasing how `{admiral}` and other packages in the pharmaverse can be used to realize the vision of full end-to-end Clinical Reporting in R.

We are also always looking for keen `{admiral}` users to publish their own blog posts about how they use the package. If this could be you, feel free make an issue in the [GitHub repo](https://github.com/pharmaverse/blog) and get started!


## Conference Presentations

* [Cross Industry Package Development](https://www.youtube.com/watch?v=M4L1PPMu0pU) (recording from R in Pharma 2022)
* [Paving the way for clinical submissions in R](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/SDE/EU/London/PRE_London09.pdf) (slides from PHUSE SDE in London)
* [An Overview of {admiral}](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/SDE/US/Summit/PRE_Summit03.pdf) (slides from PHUSE SDE in Summit, NJ)
* [{admiralonco}](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/Connect/US/Florida/REC_OS12.mp4) (recording for talk at PHUSE US Connect 2023, slides also available [here](https://phuse.s3.eu-central-1.amazonaws.com/Archive/2023/Connect/US/Florida/PRE_OS12.pdf))
Expand All @@ -172,4 +179,4 @@ We use the following for support and communications between user and developer c
## Acknowledgments

Along with the authors and contributors, thanks to the following people for their work on the package:
Jaxon Abercrombie, Mahdi About, Teckla Akinyi, James Black, Claudia Carlucci, Bill Denney, Alice Ehmann, Ania Golab, Alana Harris, Anthony Howard, Shimeng Huang, Samia Kabi, James Kim, John Kirkpatrick, Leena Khatri, Konstantina Koukourikou, Pavan Kumar, Wenyi Liu, Jack McGavigan, Jordanna Morrish, Syed Mubasheer, Yohann Omnes, Barbara O'Reilly, Hamza Rahal, Nick Ramirez, Tom Ratford, Tamara Senior, Sophie Shapcott, Ondrej Slama, Andrew Smith, Daniil Stefonishin, Vignesh Thanikachalam, Michael Thorpe, Annie Yang, Ojesh Upadhyay and Franciszek Walkowiak.
Jaxon Abercrombie, Mahdi About, Teckla Akinyi, James Black, Claudia Carlucci, Bill Denney, Kamila Duniec, Alice Ehmann, Ania Golab, Alana Harris, Declan Hodges, Anthony Howard, Shimeng Huang, Samia Kabi, James Kim, John Kirkpatrick, Leena Khatri, Robin Koeger, Konstantina Koukourikou, Pavan Kumar, Pooja Kumari, Shan Lee, Wenyi Liu, Jack McGavigan, Jordanna Morrish, Syed Mubasheer, Yohann Omnes, Barbara O'Reilly, Hamza Rahal, Nick Ramirez, Tom Ratford, Tamara Senior, Sophie Shapcott, Ondrej Slama, Andrew Smith, Daniil Stefonishin, Vignesh Thanikachalam, Michael Thorpe, Annie Yang, Ojesh Upadhyay and Franciszek Walkowiak.
6 changes: 6 additions & 0 deletions inst/WORDLIST
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Creat
Creatine
Creatinine
D'Agostino
Duniec
DAIDs
DIABP
DILI
Expand All @@ -79,6 +80,7 @@ DTM
DURD
Datetime
Daniil
Declan
Denney
DuBois
Durations
Expand Down Expand Up @@ -110,6 +112,7 @@ GxP
HDL
Haptoglobin
Hamza
Hodges
Hoffmann
Hy's
Hypercalcemia
Expand All @@ -129,7 +132,9 @@ INR
Jaxon
Jordanna
Kabi
Kamila
Khatri
Koeger
Konstantina
Koukourikou
Kumar
Expand All @@ -138,6 +143,7 @@ LDL
LLC
LLOQ
LOCF
Lee
Leena
Leukocytosis
Lipase
Expand Down
6 changes: 1 addition & 5 deletions man/admiral-package.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.