Fixes for rendering partial views #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only external change is that partials must be echoed. They don't output themselves.
phalcon
pushed a commit
that referenced
this pull request
Jul 5, 2012
Fixes for rendering partial views
|
Hi Jere, thanks for this fix, also, i believe there is a problem with PHP_EOL, check: http://travis-ci.org/#!/phalcon/cphalcon/builds/1785455 |
|
I also notice the other failures. I didn't run those tests. I will figure out and fix those problems after I get off work. |
ovr
pushed a commit
to ovr/cphalcon
that referenced
this pull request
Dec 25, 2013
Fix files missing in new projects
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a lot of the render methods to return strings instead of directly calling setContent. It does result in some repetitive code which could probably be refactored to be cleaner. I'm happy to do that if you would like.
The benefit of that is that partial views can render without calling setContent. They do have to be echo'd now which is a change to their usage, but I just couldn't think of a solution that kept their current usage without rewriting the entire thing. I took the easy way out. :)
I also added a test case for multiple partial views and modified the rest of the views tests so that they pass on Windows. Using PHP_EOL instead of a hard coded "\n" should let them pass on Linux and Windows.