-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#16293 - Add ext/pcre/php_pcre.h
header for PHP8.2
#16296
Conversation
build/config/phalcon_c_header.php
Outdated
@@ -56,6 +56,10 @@ | |||
#include <ext/spl/spl_iterators.h> | |||
#include <ext/spl/spl_array.h> | |||
|
|||
#if PHP_VERSION_ID >= 80200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the condition is needed.
This is part of the PHP API, always there
The failure on 8.2 may be related to the include of this file in another header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, better to use:
#if defined ZEPHIR_USE_PHP_PCRE && ZEPHIR_USE_PHP_PCRE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build with success using revelant part:
, https://git.remirepo.net/cgit/rpms/php/php-phalcon5.git/tree/phalcon-php82.patch
Thank you @remicollet |
Hello!
Type: bug fix
In raising this pull request, I confirm the following:
Small description of change:
Thanks