Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16293 - Add ext/pcre/php_pcre.h header for PHP8.2 #16296

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Feb 28, 2023

Hello!

Type: bug fix

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@Jeckerson Jeckerson self-assigned this Feb 28, 2023
@Jeckerson Jeckerson added bug A bug report 5.0 The issues we want to solve in the 5.0 release labels Feb 28, 2023
@Jeckerson Jeckerson requested a review from niden February 28, 2023 10:29
@Jeckerson Jeckerson marked this pull request as ready for review February 28, 2023 10:46
@@ -56,6 +56,10 @@
#include <ext/spl/spl_iterators.h>
#include <ext/spl/spl_array.h>
#if PHP_VERSION_ID >= 80200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the condition is needed.
This is part of the PHP API, always there

The failure on 8.2 may be related to the include of this file in another header.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, better to use:

#if defined ZEPHIR_USE_PHP_PCRE && ZEPHIR_USE_PHP_PCRE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Contributor

@remicollet remicollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niden niden merged commit 84f2f77 into 5.0.x Feb 28, 2023
@niden niden added the status: high High label Feb 28, 2023
@niden niden deleted the #16293-pcre-php8.2 branch February 28, 2023 14:19
@niden
Copy link
Member

niden commented Feb 28, 2023

Thank you @remicollet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

[BUG]: build failure with PHP 8.2 using bundled libpcre2 [BUG]: Unable to install using pecl on PHP 8.2
3 participants