#16293 - Add ext/pcre/php_pcre.h header for PHP8.2
#16296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeckerson
added
bug
This was
linked to
issues
Feb 28, 2023
remicollet
reviewed
Feb 28, 2023
build/config/phalcon_c_header.php
Outdated
| @@ -56,6 +56,10 @@ | |||
| #include <ext/spl/spl_iterators.h> | |||
| #include <ext/spl/spl_array.h> | |||
|
|
|||
| #if PHP_VERSION_ID >= 80200 | |||
There was a problem hiding this comment.
I don't think the condition is needed.
This is part of the PHP API, always there
The failure on 8.2 may be related to the include of this file in another header.
There was a problem hiding this comment.
IMHO, better to use:
#if defined ZEPHIR_USE_PHP_PCRE && ZEPHIR_USE_PHP_PCRE
remicollet
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Build with success using revelant part:
, https://git.remirepo.net/cgit/rpms/php/php-phalcon5.git/tree/phalcon-php82.patch
niden
approved these changes
Feb 28, 2023
|
Thank you @remicollet |
This was referenced Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Type: bug fix
In raising this pull request, I confirm the following:
Small description of change:
Thanks