Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15776 text helper str #15786

Merged
merged 45 commits into from
Nov 16, 2021
Merged

T15776 text helper str #15786

merged 45 commits into from
Nov 16, 2021

Conversation

niden
Copy link
Member

@niden niden commented Nov 16, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Removed Phalcon\Text

Thanks

@niden
removed text class from ext
f5e49ef
@niden
removed Str static class
1eef498
@niden
Removed references for Text:: and the class itself; Removed Helper\St…
32a6477 
…r and references
@niden
adjusted tests
b16b65c
@niden
removing helper\number from ext
a45aef2
@niden
removed references to number::
3fd963b
@niden
refreshing ext/
10a2b27
@niden
removed helper\arr and references
e811336
@niden
adjusted code without helper\arr
31824d0
@niden
another ext refresh
ba30337
@niden
removed helper\base64
4b361bc
@niden
adjusted code without helper\ methods
1155fd8
@niden
removed helper\json
20161cf
@niden
refreshing ext/
b2f9ff6
@niden
corrections after removing Helper
538316f
@niden
removing root files to regenerate them
9f092bf
@niden
another ext refresh
055e15b
@niden
corrections to filter, escaper, link
307189a
@niden
added more tests - sync with phalcon
117045d
@niden
refreshing ext
02dea2e
@niden
psalm docblock correction
073713d
@niden
corrections to the logic; added better docblocks for filter
9c3b99c
@niden
correcting tests
2b6ff86
@niden
removing di from the top level
4af0cbf
@niden
typo corrections; added tagFactory for debug constructor
5515b25
@niden
sync with phalcon; test corrections and code coverage
e3588d4
@niden
cosmetic changes
301727f
@niden
refreshing ext
1c3e1c5
@niden
removing obsolete files
e378162
@niden
correcting dump builds for windows line endings
c72d09d
@niden niden self-assigned this Nov 16, 2021
@niden niden requested a review from Jeckerson November 16, 2021 20:02
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report new feature request Planned Feature or New Feature Request status: low Low labels Nov 16, 2021
This was linked to issues Nov 16, 2021
[NFR]: Remove Text and Helper\Str replace it with Support\Helper\Str #15776
Closed
[BUG]: Uncaught Phalcon\Tag\Exception with Phalcon\Debug and Phalcon\Session\Bag #15381
Closed
Jeckerson
Jeckerson previously approved these changes Nov 16, 2021
View reviewed changes
@niden niden merged commit 5997ef8 into phalcon:5.0.x Nov 16, 2021
@niden niden deleted the T15776-text-helper-str branch November 16, 2021 20:56
This was referenced Nov 16, 2021
Closed
Closed
@niden niden linked an issue Nov 16, 2021 that may be closed by this pull request
[NFR]: Align Asset/Html tests #15756
Closed
@niden niden mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report new feature request Planned Feature or New Feature Request status: low Low
Projects
None yet
Milestone
No milestone
2 participants
@niden @Jeckerson