Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface changes 4 #14381

Merged
merged 12 commits into from
Sep 12, 2019
Merged

Interface changes 4 #14381

merged 12 commits into from
Sep 12, 2019

Conversation

niden
Copy link
Member

@niden niden commented Sep 12, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Corrected interfaces; Regenerated ext

Thanks

@niden niden added 4.0 enhancement Enhancement to the framework labels Sep 12, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #14381 into 4.0.x will decrease coverage by 0.14%.
The diff coverage is 58.97%.

@@            Coverage Diff             @@
##            4.0.x   #14381      +/-   ##
==========================================
- Coverage   67.78%   67.63%   -0.15%     
==========================================
  Files         478      478              
  Lines      112932   110975    -1957     
==========================================
- Hits        76548    75056    -1492     
+ Misses      36384    35919     -465

@niden niden merged commit 817d2d2 into phalcon:4.0.x Sep 12, 2019
@ruudboon
Copy link
Member

@niden Do we need doc changes?

@niden
Copy link
Member Author

niden commented Sep 12, 2019

@ruudboon Already done

@niden niden deleted the interface-changes-4 branch September 12, 2019 21:44
@ruudboon
Copy link
Member

@niden 👌🤘💪🏻

@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report enhancement Enhancement to the framework status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants