Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13954 Arr::whiteList() #14182

Merged
merged 2 commits into from
Jun 14, 2019
Merged

T13954 Arr::whiteList() #14182

merged 2 commits into from
Jun 14, 2019

Conversation

emiliodeg
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
It's a little function to get some elements by key from a whitelist of keys
Thanks

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #14182 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14182      +/-   ##
==========================================
+ Coverage   74.64%   74.64%   +<.01%     
==========================================
  Files         455      455              
  Lines       94417    94441      +24     
==========================================
+ Hits        70473    70497      +24     
  Misses      23944    23944
Impacted Files Coverage Δ
ext/phalcon.c 97.65% <0%> (ø) ⬆️
ext/phalcon/helper/arr.zep.c 98.47% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b843304...4a0a921. Read the comment docs.

@niden niden merged commit 99066eb into phalcon:4.0.x Jun 14, 2019
@niden
Copy link
Member

niden commented Jun 14, 2019

Thank you @emiliodeg

@niden niden added documentation Documentation required enhancement Enhancement to the framework labels Jun 14, 2019
@emiliodeg emiliodeg deleted the T13954-arr-white-list branch June 15, 2019 19:30
@niden niden removed the documentation Documentation required label Jul 6, 2019
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants