-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T13672 factories #14097
Merged
Merged
T13672 factories #14097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
suggested changes
May 20, 2019
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14097 +/- ##
=========================================
- Coverage 71.59% 70.99% -0.6%
=========================================
Files 488 441 -47
Lines 95798 93501 -2297
=========================================
- Hits 68582 66384 -2198
+ Misses 27216 27117 -99
Continue to review full report at Codecov.
|
@sergeyklay see my response above. Also I will regenerate |
This reverts commit 9e5a408.
sergeyklay
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Added
Phalcon\Factory\Exception
for factory exceptions.Phalcon\Filter\FilterInterface
for custom filter implementations.Phalcon\Db\Adapter\PdoFactory
: Factory to create PDO adapters.Phalcon\Image\ImageFactory
: Factory to create image adapters.Phalcon\Image\LoggerFactory
: Factory to create logger objects.Phalcon\Translate\InterpolatorFactory
: Factory to create interpolator objects.Phalcon\Translate\TranslateFactory
: Factory to create translate objects.Changed
Phalcon\Annotations\Adapter\Files
toPhalcon\Annotations\Adapter\Stream
.Phalcon\Annotations\Adapter
toPhalcon\Annotations\Adapter\AbstractAdapter
.Phalcon\Annotations\AdapterInterface
toPhalcon\Annotations\Adapter\AdapterInterface
. #13672Phalcon\Annotations\Factory
toPhalcon\Annotations\AnnotationsFactory
.Phalcon\Config\Factory
toPhalcon\Config\ConfigFactory
.Phalcon\Filter\FilterLocator
toPhalcon\Filter\Filter
.Phalcon\Filter\FilterLocatorFactory
toPhalcon\Filter\FilterFactory
.Phalcon\Image\Adapter
toPhalcon\Image\Adapter\AbstractAdapter
.Phalcon\Image\AdapterInterface
toPhalcon\Image\Adapter\AdapterInterface
.Phalcon\Paginator\Adapter
toPhalcon\Paginator\Adapter\AbstractAdapter
.Phalcon\Paginator\AdapterInterface
toPhalcon\Paginator\Adapter\AdapterInterface
.Phalcon\Paginator\Factory
toPhalcon\Paginator\PaginatorFactory
.Removed
Phalcon\Session\Factory
.Phalcon\Factory
andPhalcon\FactoryInterface
.Thanks