Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13672 factories #14097

Merged
merged 28 commits into from
May 20, 2019
Merged

T13672 factories #14097

merged 28 commits into from
May 20, 2019

Conversation

niden
Copy link
Member

@niden niden commented May 20, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added

  • Added Phalcon\Factory\Exception for factory exceptions.
  • Added Phalcon\Filter\FilterInterface for custom filter implementations.
  • Added Phalcon\Db\Adapter\PdoFactory: Factory to create PDO adapters.
  • Added Phalcon\Image\ImageFactory: Factory to create image adapters.
  • Added Phalcon\Image\LoggerFactory: Factory to create logger objects.
  • Added Phalcon\Translate\InterpolatorFactory: Factory to create interpolator objects.
  • Added Phalcon\Translate\TranslateFactory: Factory to create translate objects.

Changed

  • Renamed Phalcon\Annotations\Adapter\Files to Phalcon\Annotations\Adapter\Stream.
  • Renamed Phalcon\Annotations\Adapter to Phalcon\Annotations\Adapter\AbstractAdapter.
  • Renamed Phalcon\Annotations\AdapterInterface to Phalcon\Annotations\Adapter\AdapterInterface. #13672
  • Renamed Phalcon\Annotations\Factory to Phalcon\Annotations\AnnotationsFactory.
  • Renamed Phalcon\Config\Factory to Phalcon\Config\ConfigFactory.
  • Renamed Phalcon\Filter\FilterLocator to Phalcon\Filter\Filter.
  • Renamed Phalcon\Filter\FilterLocatorFactory to Phalcon\Filter\FilterFactory.
  • Renamed Phalcon\Image\Adapter to Phalcon\Image\Adapter\AbstractAdapter.
  • Renamed Phalcon\Image\AdapterInterface to Phalcon\Image\Adapter\AdapterInterface.
  • Renamed Phalcon\Paginator\Adapter to Phalcon\Paginator\Adapter\AbstractAdapter.
  • Renamed Phalcon\Paginator\AdapterInterface to Phalcon\Paginator\Adapter\AdapterInterface.
  • Renamed Phalcon\Paginator\Factory to Phalcon\Paginator\PaginatorFactory.

Removed

  • Removed Phalcon\Session\Factory.
  • Removed Phalcon\Factory and Phalcon\FactoryInterface.

Thanks

@niden niden added the enhancement Enhancement to the framework label May 20, 2019
@niden niden added the documentation Documentation required label May 20, 2019
phalcon/Annotations/Adapter/Stream.zep Outdated Show resolved Hide resolved
phalcon/Config/ConfigFactory.zep Show resolved Hide resolved
phalcon/Factory/AbstractFactory.zep Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #14097 into 4.0.x will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            4.0.x   #14097     +/-   ##
=========================================
- Coverage   71.59%   70.99%   -0.6%     
=========================================
  Files         488      441     -47     
  Lines       95798    93501   -2297     
=========================================
- Hits        68582    66384   -2198     
+ Misses      27216    27117     -99
Impacted Files Coverage Δ
ext/phalcon/paginator/adapter/querybuilder.zep.c 12.25% <0%> (-68.78%) ⬇️
ext/phalcon/3__closure.zep.c 16.66% <0%> (-65.16%) ⬇️
ext/phalcon/4__closure.zep.c 16.66% <0%> (-65.16%) ⬇️
ext/phalcon/1__closure.zep.c 23.07% <0%> (-58.75%) ⬇️
ext/phalcon/2__closure.zep.c 37.5% <0%> (-44.32%) ⬇️
ext/phalcon/events/event.zep.c 60.86% <0%> (-26.09%) ⬇️
ext/phalcon/paginator/repository.zep.c 83.41% <0%> (-5.53%) ⬇️
ext/phalcon/logger/loggerfactory.zep.c 74.54% <0%> (-5.46%) ⬇️
ext/phalcon/config/adapter/grouped.zep.c 88.88% <0%> (-3.87%) ⬇️
ext/phalcon/storage/adapterfactory.zep.c 90.78% <0%> (-2.97%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b53e8...39741ee. Read the comment docs.

@niden
Copy link
Member Author

niden commented May 20, 2019

@sergeyklay see my response above. Also I will regenerate ext/ after this is merged

@niden niden merged commit 8687233 into phalcon:4.0.x May 20, 2019
@niden niden added the 4.0 label Oct 15, 2019
@niden niden removed the documentation Documentation required label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants