Removed assigning properties via save() in models (as per #12317) #13945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.0.x #13945 +/- ##
==========================================
- Coverage 67.64% 67.64% -0.01%
==========================================
Files 469 469
Lines 94350 94352 +2
==========================================
Hits 63821 63821
- Misses 30529 30531 +2
Continue to review full report at Codecov.
|
sergeyklay
previously approved these changes
Apr 5, 2019
Jeckerson
previously approved these changes
Apr 5, 2019
niden
added
breaks bc
|
Need a rebase on this bud @SidRoberts |
niden
approved these changes
Apr 6, 2019
|
Thank you @SidRoberts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Forgot to update some of the docblocks with the changes made in #12317 and I missed one code reference in Mvc\Model\Resultset that still tried to assign data whilst saving. I can only assume that it's in a method that isn't used very much as no one has complained since the original PR merged 2 years ago. 😮