Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13543] Add more pdo types #13562

Merged
merged 100 commits into from
Dec 4, 2018
Merged

[#13543] Add more pdo types #13562

merged 100 commits into from
Dec 4, 2018

Conversation

niden
Copy link
Member

@niden niden commented Oct 31, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

This PR consolidates issues and PRs. Types supported for MySQL:

  • TYPE_BIGINTEGER
  • TYPE_BIT
  • TYPE_BLOB
  • TYPE_BOOLEAN
  • TYPE_CHAR
  • TYPE_DATE
  • TYPE_DATETIME
  • TYPE_DECIMAL
  • TYPE_DOUBLE
  • TYPE_ENUM
  • TYPE_FLOAT
  • TYPE_INTEGER
  • TYPE_JSON
  • TYPE_JSONB
  • TYPE_LONGBLOB
  • TYPE_LONGTEXT
  • TYPE_MEDIUMBLOB
  • TYPE_MEDIUMINTEGER
  • TYPE_MEDIUMTEXT
  • TYPE_SMALLINTEGER
  • TYPE_TEXT
  • TYPE_TIME
  • TYPE_TIMESTAMP
  • TYPE_TINYBLOB
  • TYPE_TINYINTEGER
  • TYPE_TINYTEXT
  • TYPE_VARCHAR

Thanks

niden added 30 commits October 23, 2018 11:07
@niden
[#13543] - Work on the ENUM for PostgreSql
43f053c
@niden
[#13543] - Adjusted tests
03d3089
@niden
[#13543] - Corrected if clause
90f2a13
@niden
[#13543] - Added enum to the PG sample file
99f456b
@niden
[#13543] - Trying to correct the sql file again
f763f8b
@niden
[#13543] - Reverting changes
c1d8116
@niden
[#13543] - Reverting tests and sql file
348d5ad
@niden
[#13543] - Initial commit for a nanobox isolated environment for tests
1f9cfbb
@niden
[#13543] - Reintroduced enum type parsing
f562759
@niden
[#13543] - Adjusted test
ccd03db
@niden
[#13543] - Again reverting some changes
2938e89
@niden
[#13543] - Reorganized the if statement
38960d9
@niden
[#13543] - Reorganized if statement
5b79624
@niden
[#13543] - More sorting
94fd2da
@niden
[#13543] - Reorganization
c1d064a
@niden
[#13543] - Added bool and bit
e32d63e
@niden
[#13543] - Added initial describe test
1a3ac05
@niden
[#13543] - Corrections to the table name and import file
5a0164d
@niden
[#13543] - Minor change to the boxfile; Added boxfile constants to th…
780f011 
…e tests; Changed case in SQL file
@niden
[#13543] - Changed JSON type to TEXT
ebeca66
@niden
[#13543] - More work on the db
26468d3
@niden
[#13543] - Another correction to the sql file
c6e6af4
@niden
[#13543] - Test corrections
c8754f0
@niden
[#13543] - Test corrections
b33c49c
@niden
[#13543] - Corrected the bind parameter type
6f6e480
@niden
[#13543] - Added more fields to the column describe test
5daa927
@niden
[#13543] - Added all the possible columns for the test
bba8fab
@niden
[#13543] - Corrected typo
a23a8cd
@niden
[#13543] - More corrections
9ef0f8a
@niden
[#13543] - Corrections to the test
17b6178
This was referenced Oct 31, 2018
Closed
Closed
@niden
Copy link
Member Author

niden commented Oct 31, 2018

cc @sergeyklay Big one for you :)

@niden niden added this to the 4.0.0 milestone Oct 31, 2018
@niden niden added the enhancement Enhancement to the framework label Oct 31, 2018
@niden niden requested a review from sergeyklay October 31, 2018 14:24
@niden niden mentioned this pull request Nov 2, 2018
Closed
@sergeyklay
Copy link
Contributor

@niden Could you please rebase

sergeyklay
sergeyklay reviewed Nov 3, 2018
View reviewed changes
boxfile.yml Outdated Show resolved Hide resolved
niden added 3 commits November 3, 2018 20:54
@niden
[#13543] - Merge branch '4.0.x' into T13543-add-more-pdo-types-3
6550484 
* 4.0.x:
  [PR12189] - Removed unused variables; Corrected missing use statement
  [PR12189] - Corrected typo
  [PR12189] - Minor changes based on review
  [PR12189] - Modified header class and corrected tests
  [PR12189] - Corrected logic and test
  [PR12189] - Fixed tests
  [PR12189] - Added test for hasHeader
  [PR12189] - Updated changelog
  [PR12189] - Added hasHeader method
  Minor CI's config refactor and improvements
  [#13547] - Updated changelog
  [#13547] - Corrected name of the method and tests
  [#13547] - Changed getTitle and added renderTitle
@niden
[#13543] - Removed boxfile - will send upstream in different commit
3662456
@niden
Merge branch '4.0.x' into T13543-add-more-pdo-types-3
c4e3071 
* 4.0.x: (33 commits)
  Updated stale to not close issues labelled as bugs
  Use latest Zephir Parser
  [#11608] - Removed unused variables
  [#11608] - Reverting instantiation of the client
  [#11608] - Removed '_' from variables and methods
  [#11608] - Refactoring on the connect to check if the object is already initialized/connected
  [#11608] - Refactoring of the getClient()
  [#11608] - Fixed tabs
  [#11608] - Corrections based on review
  [#10532] - Corrected variable
  [#10532] - Updated changelog
  [#10532] - Added case insensitive column map in model
  [#11608] - Corrected variable name
  [#11608] - Corrected costructor and changelog
  [#11608] - Updated the changelog
  [#11608] - Corrected tests
  [#11608] - Fixed typos
  [#11608] - More corrections
  [#11608] - Modifications to the class; Adjusted tests
  [#11608] - Changed the comparison for the key on save
  ...
niden added 3 commits November 28, 2018 19:08
@niden
[#13543] - Merge branch '4.0.x' into T13543-add-more-pdo-types-3
6a72130 
* 4.0.x: (21 commits)
  Fixed broken view test
  AppVeyor use latest Zephir
  Use latest Zephir from the 0.10.x branch [skip appveyor]
  Fixes #13351: Numeric config properties merge correctly now
  fix issue 13351 merge config on non-zero-based numeric index
  Added method to check is a relationship is loaded
  Updated Changelog [ci skip]
  Fixed #12725: Numeric INI config now builds properly
  Fixed default PHP config filename [skip appveyor]
  Add code coverage support [skip appveyor]
  Add `Phalcon\Http\Response\Cookies::getCookies`.
  Add `Phalcon\Http\Response\Cookies::getCookies`.
  Fixed AppVeyor build [skip travis]
  Update build/test deps for AppVeyor
  Update build/test deps for Travis CI
  Update CHANGELOG-4.0.md
  add offset to query builder
  Add changelog entry.
  Remove name property from Service.
  Remove name property from Service.
  ...
@niden
[#13543] - Reformatted class to trigger build
5294309
@niden
[#13543] - Corrected names of schema files
163258a
@zGaron
Copy link

zGaron commented Nov 29, 2018

cool

@sergeyklay sergeyklay added new feature request Planned Feature or New Feature Request and removed enhancement Enhancement to the framework labels Dec 1, 2018
@niden niden merged commit c0af848 into phalcon:4.0.x Dec 4, 2018
@niden niden deleted the T13543-add-more-pdo-types-3 branch December 5, 2018 03:11
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Dec 1, 2019
@niden niden removed this from the 4.0.0 milestone Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niden @sergeyklay @zGaron