Fixed Phalcon\Mvc\ModelInterface to include getModelsMetaData().

[virgofx]

Fixed Phalcon\Mvc\ModelInterface to include getModelsMetaData(). This is important for static analysis as the ModelInterface is used as the interface parameter for various plugins and user components.

[virgofx]

ping @sergeyklay . Need me to submit 4.0.x also?

[sergeyklay]

I'll cherry pick this to the 4.0.x a bit later if the need arises. Thank you for contributing. Could you please return back the changes in the phalcon/mvc/model.zep related to import classes.

[virgofx]

The 2 imports that were removed were:

use Phalcon\Validation\Message\Group;
use Phalcon\Validation\Message\Group as ValidationMessageGroup;

They are both not used + duplicated. The other imports were reordered alphabetically.

What are you suggesting? To re-add the above imports, despite them being not used? Everything works/builds . Shouldn't need to re-add unused imports ...

[sergeyklay]

Actually I prefer to keep it as is (unordered) and just add new ones to decrease diff.

[virgofx]

It's not about the diff.... It's about correctness. 2 of the imports are not used and shouldn't be imported.

[Jurigag]

Btw, shouldn't this change aim 4.0.x? #12676 i will add it there Oh wait we will do anyway changes to ORM so i guess this method will be deleted. To be honest i don't even know if we need this change.

[sergeyklay]

@virgofx I see 14 additions and 17 deletions in this file and would like to see only 2 deletions.

[sergeyklay]

@virgofx Removed not used imports in the #13089. Could you please rebase

[virgofx]

Rebased .. but left alphabetized as that's how coding standard is. The reason for the extra deletion is because there was another duplicate Phalcon\Mvc\Model\Message which was missed as result of poor diffing tool (not my fault). Imports should always be optimized/alphabetically as this is consistent with the entire code baseline. Please merge.

[sergeyklay]

We can't change any interface in minor release. Thus I added this to the 4.0.0 milestone.

[sergeyklay]

Also just to you know there is no benefit from ordering imports in code which will be compiled and optimized before release

[virgofx]

I agree compiled code doesn't care; however, the coding standard and those contributing all follow best practices. No reason not to keep things inline best practice. If this is for the 4.0 milestone ... will you fix in a separate PR then with the rest of the interfaces?

[virgofx]

Best practice would also have moving a lot of the constants from Classes into Interfaces as well.

If this won't be merged do you want me to submit to 4.0 or will you handle with interface cleanup everywhere in 4.0? If so, want me to close?
ping @sergeyklay

[sergeyklay]

@virgofx Could you please send this PR to the 4.0.x branch?

[virgofx]

I could but is 4.0 selectively cherry picking commits? Seems like it would miss core functionality from 3.x? Just making sure other 3.x stuff is also in 4.0?

[sergeyklay]

The 4.0.x branch is actual now.