Add filter to manager so CSS and JS resources are not mixed when outputing by type #12915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ninjapanzer Could you please update the |
ninjapanzer
force-pushed
the
pks/asset_manager_with_mixed_resource_collection
branch
4 times, most recently
from
db3c7f1 to
ec020d2
Compare
ninjapanzer
force-pushed
the
pks/asset_manager_with_mixed_resource_collection
branch
from
ec020d2 to
52b3fa4
Compare
|
@sergeyklay ChangeLog Updated. |
Jurigag
reviewed
Jun 21, 2017
CHANGELOG.md
Outdated
| @@ -46,6 +46,7 @@ | |||
| - Fixed `Phalcon\Cache\Backend\Redis::__construct` and `Phalcon\Cache\Backend\Redis::_connect` to correctly handle the Redis auth option [#12736](https://github.com/phalcon/cphalcon/issues/12736) | |||
| - Fixed `Phalcon\Mvc\Collection::getReservedAttributes`, added missing properties to reserved attributes [phalcon/incubator#762](https://github.com/phalcon/incubator/issues/762), [phalcon/incubator#760](https://github.com/phalcon/incubator/issues/760) | |||
| - Fixed `Phalcon\Mvc\Router\Annotation::processActionAnnotation` to support PATCH request | |||
| - Fixed `Phalcon\Assets\Manager::output`, implemented missing resource type filtering for mixed resource collections [#2408](https://github.com/phalcon/cphalcon/issues/2408) | |||
There was a problem hiding this comment.
This needs to be on 3.2.1 block.
There was a problem hiding this comment.
Right... sorry, fixed.
ninjapanzer
force-pushed
the
pks/asset_manager_with_mixed_resource_collection
branch
from
52b3fa4 to
765d74b
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
This PR adds a filter method which returns a new copy of the collection resources array that only includes the supplied type. So that a collection an contain a mix of JS and CSS resources so that:
outputJswill only return js resources from that collectionoutputCsswill only return css resources from that collectionThanks
Paul Scarrone(ninjapanzer)[email protected]