3.2.x Model hasChanged array #12713
Merged
3.2.x Model hasChanged array #12713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurigag
changed the title
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
from
bfe81c5 to
86a14a0
Compare
sergeyklay
suggested changes
Mar 15, 2017
phalcon/mvc/model.zep
Outdated
| @@ -3853,7 +3853,7 @@ abstract class Model implements EntityInterface, ModelInterface, ResultInterface | |||
| * | |||
| * @param string|array fieldName | |||
| */ | |||
| public function hasChanged(var fieldName = null) -> boolean | |||
| public function hasChanged(var fieldName = null, boolean allFields = false) -> boolean | |||
There was a problem hiding this comment.
Could you please amend PHPDoc with example and update CHANELOG.md?
There was a problem hiding this comment.
Yea i will update changelog once there will be 3.2.x branch cuz i will need to update it then anyway.
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
2 times, most recently
from
cae32fb to
4ad2aa6
Compare
|
rebased @sergeyklay |
sergeyklay
suggested changes
Mar 23, 2017
phalcon/mvc/model.zep
Outdated
| * $robot->type = "hydraulic"; | ||
| * $hasChanged = $robot->hasChanged("type"); // returns true | ||
| * $hasChanged = $robot->hasChanged(["type", "name"]); // returns true | ||
| * $hasChanged = $robot->hasChanged(["type", "name", true]); // returns false |
There was a problem hiding this comment.
$robot->hasChanged(["type", "name"], true);There was a problem hiding this comment.
Oh, okay i see space.
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
from
4ad2aa6 to
cca9cd1
Compare
|
Fixed comment. |
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
from
cca9cd1 to
1c6a7fb
Compare
Jurigag
changed the title
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
2 times, most recently
from
39870c4 to
10c2c3f
Compare
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
from
10c2c3f to
090064c
Compare
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
2 times, most recently
from
d8c8fe2 to
5465096
Compare
|
Rebased @sergeyklay |
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
from
de5f52e to
2fa99a3
Compare
Jurigag
force-pushed
the
3.2.x-model-haschanged
branch
from
2fa99a3 to
7394bcc
Compare
|
Rebased @phalcon/framework-team |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: This is fixing issue as well adding option to check if array of fields was changed in models with ability to check if all provided fields were changed.
Thanks