Phalcon\Session\Bag: add of initialization for remove()

[morafabio]

• Type: bug fix
• Issue: when Phalcon\Session\Bag is restored by the session handler, the _data property results not initialized and remove() won't work properly.

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the Contributing Guidelines?
• I have checked that another pull request for this purpose does not exist.
• I wrote some tests for this PR.

Small description of change: Initialization steps in remove() have been added.

Steps to reproduce:

// debug with reflection
$reflectionClass = new \ReflectionClass(get_class($this->bag));
$_data = $reflectionClass->getProperty('_data');
$_data->setAccessible(true);
$_initialized = $reflectionClass->getProperty('_initialized');
$_initialized->setAccessible(true);

// create a Bag with one value
$bag = new \Phalcon\Session\Bag('fruit');
$bag->set('apples', 10);
var_dump($bag->get('apples')); // int(10)
var_dump($_data->getValue($bag)); // array(1) { ["apples"]=> int(10) }
var_dump($_initialized->getValue($bag)); // bool(true)

// save and cleanup
$serializedBag = serialize($bag);
unset($bag);

// emulate restore in the same way it would be done
// any PHP session handler, e.g.: `session.save_handler => redis => redis`
$bag = unserialize($serializedBag);
$_data->setValue($bag, NULL);
$_initialized->setValue($bag, false);

// remove attempt fails because `_data` is NULL
var_dump($bag->remove('apples')); // bool(false) // EXPECTED: bool(true)
var_dump($bag->get('apples')); // int(10) // EXPECTED: NULL

// get performs _initialize under the hood, so now it works
var_dump($bag->remove('apples')); // bool(true)
var_dump($bag->get('apples')); // NULL

this calls initialize also on Bag::remove.

Run tests: vagrant@phalcon:~/cphalcon$ vendor/bin/codecept run tests/unit/Session/BagTest

Thanks

[sergeyklay]

Could you please add this to bottom of the [3.1.0] section?

[morafabio]

Done

[morafabio]

@sergeyklay ManagerTest|ModelTest looks failing but I have no idea on how this is related to my change. Any hint :)?

[morafabio]

Hum... Looks the the build of 3.1.0 was already failing: https://travis-ci.org/phalcon/cphalcon/jobs/203022574

[sergeyklay]

Will be fixed after #12644

[morafabio]

Ok, so do you need me to fix something other?

[sergeyklay]

I'll take a look later. Thank you for contributing.

[morafabio]

👍

[sergeyklay]

Thank you. Merged to the 3.1.x