fix compilation when imagemagick is v7 #12493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
suggested changes
Dec 22, 2016
|
|
||
| preg_match("/ImageMagick ([0-9]+\.[0-9]+\.[0-9]+)/", imagickVersion["versionString"], imagickVersion); | ||
|
|
||
| if version_compare(imagickVersion[1], '7') < 0 { |
|
Also could you please update |
will squash this one after that
|
why not use method_exists? |
|
well i might have to cuz preg_match might be broken in php5 ( for zephir ) , but if I use method exists , if they change that shit again in imagick 8 the code will look funny xD am at work atm so i dont have much time i will check it tonight to find a good looking work around |
|
@Izopi4a Well, as you can see tests fails |
|
i will fix windows build these days because i need to dig into that |
|
|
…halcon into imagemagick-7-support
|
Fixed in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
when image magick version is 7 compilation fails
Imagick/imagick#180