Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Division by zero when limit=0 in Paginator #14303

Closed
ruudboon opened this issue Aug 16, 2019 · 1 comment
Closed

Division by zero when limit=0 in Paginator #14303

ruudboon opened this issue Aug 16, 2019 · 1 comment
Assignees
@ruudboon
Labels
bug A bug report status: low Low

Comments

@ruudboon
Copy link
Member

ruudboon commented Aug 16, 2019 •
edited
Loading

When setting limit to < 1 on Paginator\Adapter\QueryBuilder a division by zero occurs.
Input should be checked to be > 0.

Phalcon 4.0.0-beta.1

Expecting an exception when setting incorrect parameters
@ruudboon ruudboon self-assigned this Sep 9, 2019
@ruudboon ruudboon mentioned this issue Sep 10, 2019
Merged
5 tasks
niden pushed a commit that referenced this issue Sep 10, 2019
@ruudboon @niden
Added test for issue #14303
ba26e2b
@niden
Copy link
Member

niden commented Sep 10, 2019

Resolved

@niden niden closed this as completed Sep 10, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruudboon ruudboon

Labels
bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niden @ruudboon