[#13648] - Minor adjustments

phalcon · May 15, 2019 · 99d9838 · 99d9838
1 parent d0d5b4e
commit 99d9838
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 72 deletions.
diff --git a/...dapter/Micro/Acl/GetDefaultAccessCest.php → ...ter/Micro/Acl/GetSetDefaultAccessCest.php b/...dapter/Micro/Acl/GetDefaultAccessCest.php → ...ter/Micro/Acl/GetSetDefaultAccessCest.php
@@ -12,20 +12,26 @@
 
 namespace Phalcon\Test\Unit\Firewall\Adapter\Micro\Acl;
 
+use Phalcon\Acl as PhAcl;
+use Phalcon\Firewall\Adapter\Micro\Acl;
 use UnitTester;
 
-class GetDefaultAccessCest
+class GetSetDefaultAccessCest
 {
     /**
-     * Tests Phalcon\Firewall\Adapter\Micro\Acl :: getDefaultAccess()
+     * Tests Phalcon\Firewall\Adapter\Micro\Acl :: getDefaultAccess()/setDefaultAccess()
      *
      * @author Phalcon Team <[email protected]>
      * @since  2019-05-12
      */
-    public function firewallAdapterMicroAclGetDefaultAccess(UnitTester $I)
+    public function firewallAdapterMicroAclGetSetDefaultAccess(UnitTester $I)
     {
-        $I->wantToTest('Firewall\Adapter\Micro\Acl - getDefaultAccess()');
+        $I->wantToTest('Firewall\Adapter\Micro\Acl - getDefaultAccess()/setDefaultAccess()');
 
-        $I->skipTest('Need implementation');
+        $firewall = new Acl('acl');
+        $firewall->setDefaultAccess(PhAcl::ALLOW);
+
+        $actual = $firewall->getDefaultAccess();
+        $I->assertEquals(PhAcl::ALLOW, $actual);
     }
 }
diff --git a/...dapter/Micro/Acl/GetEventsManagerCest.php → ...ter/Micro/Acl/GetSetEventsManagerCest.php b/...dapter/Micro/Acl/GetEventsManagerCest.php → ...ter/Micro/Acl/GetSetEventsManagerCest.php
@@ -12,20 +12,28 @@
 
 namespace Phalcon\Test\Unit\Firewall\Adapter\Micro\Acl;
 
+use Phalcon\Events\Manager;
+use Phalcon\Firewall\Adapter\Micro\Acl;
 use UnitTester;
 
-class GetEventsManagerCest
+class GetSetEventsManagerCest
 {
     /**
-     * Tests Phalcon\Firewall\Adapter\Micro\Acl :: getEventsManager()
+     * Tests Phalcon\Firewall\Adapter\Micro\Acl :: getEventsManager()/setEventsManager()
      *
      * @author Phalcon Team <[email protected]>
      * @since  2019-05-12
      */
-    public function firewallAdapterMicroAclGetEventsManager(UnitTester $I)
+    public function firewallAdapterMicroAclGetSetEventsManager(UnitTester $I)
     {
-        $I->wantToTest('Firewall\Adapter\Micro\Acl - getEventsManager()');
+        $I->wantToTest('Firewall\Adapter\Micro\Acl - getEventsManager()/setEventsManager()');
 
-        $I->skipTest('Need implementation');
+        $firewall = new Acl('acl');
+        $eventsManager = new Manager();
+
+        $firewall->setEventsManager($eventsManager);
+
+        $actual = $firewall->getEventsManager();
+        $I->assertEquals($eventsManager, $actual);
     }
 }
diff --git a/tests/unit/Firewall/Adapter/Micro/Acl/SetCacheCest.php b/tests/unit/Firewall/Adapter/Micro/Acl/SetCacheCest.php
@@ -27,6 +27,7 @@
 use Phalcon\Test\Fixtures\Traits\DiTrait;
 use Phalcon\Test\Fixtures\Traits\FirewallTrait;
 use Phalcon\Test\Models\AlbumORama\Albums;
+use function sleep;
 use UnitTester;
 
 class SetCacheCest
@@ -173,6 +174,11 @@ function (BindingRole $user) {
         );
         $I->assertEquals($returnedValue, $example[2]);
         $I->assertEquals($cache->get('_PHF_')[$example[3]], $example[4]);
+
+        /**
+         * Hack to remove the too many connections
+         */
+        sleep(1);
     }
 
     /**

diff --git a/tests/unit/Firewall/Adapter/Micro/Acl/SetDefaultAccessCest.php b/tests/unit/Firewall/Adapter/Micro/Acl/SetDefaultAccessCest.php
diff --git a/tests/unit/Firewall/Adapter/Micro/Acl/SetEventsManagerCest.php b/tests/unit/Firewall/Adapter/Micro/Acl/SetEventsManagerCest.php