Rasusa #125
Merged
Rasusa #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to version 0.4.0
Fix `README.md`
fixed link
updated nextflow schema for ectyper.
|
emarinier
requested changes
Oct 2, 2024
CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### `Changed` | |||
|
|
|||
| - Added RASUSA for downsampling of nanopore or pacbio data. | |||
There was a problem hiding this comment.
Nanopore, PacBio capitalization
There was a problem hiding this comment.
fixed in: 667b67d
docs/usage/tool_params.md
Outdated
| @@ -52,7 +52,16 @@ Seqtk is used for both the sub-sampling of reads and conversion of fasta files t | |||
| - seed: A seed value for sub-sampling | |||
| - reads_ext: Extension of reads after sub-sampling, do not touch alter this unless doing pipeline development. | |||
| - assembly_fastq: Extension of the fastas after being converted to fastq files. Do no touch this unless doing pipeline development. | |||
| - report_tag: Name of seqtk data in the final summary report. Do no touch this unless doing pipeline development. | |||
| - report_tag: Name of seqtk data in the fi nal summary report. Do no touch this unless doing pipeline development. | |||
There was a problem hiding this comment.
fixed in: 667b67d
docs/usage/tool_params.md
Outdated
Comment on lines
58
to
64
| For long read data Rasusa is used for down sampling as it take read length into consideration when down sampling. | ||
|
|
||
| - rasusa | ||
| - singularity: singularity container for rasusa | ||
| - docker: docker container for rasusa | ||
| - seed: A seed value for sub-sampling | ||
| - reads_ext: The extension of the generated fastq files. Do no touch this unless doing pipeline development. |
There was a problem hiding this comment.
downsamping is probably one word
Singularity, Docker capitalization
Also consider: "do not change this" instead of "do not touch this"
There was a problem hiding this comment.
fixed in: 667b67d
Comment on lines
49
to
50
| assert workflow.success | ||
| snapshot(workflow.out).match() |
There was a problem hiding this comment.
Are there any other tests that could be done here? Number of reads, first read, metrics, files exist, etc.?
Same comment for the tests below.
There was a problem hiding this comment.
fixed in: 667b67d
emarinier
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding RASUSA for downsampling of nanopore data.