Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Installation Documenation #1563

Merged
merged 10 commits into from
Dec 20, 2024
Merged

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Dec 17, 2024

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

This PR updates installation documentation with instructions for tomcat9 and ubuntu 24.04

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

* [ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
* [ ] Tests added (or description of how to test) for any new features.
* [ ] User documentation updated for UI or technical changes.

Copy link
Member

@JeffreyThiessen JeffreyThiessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed to make commands work.

doc/administrator/web/ubuntu/index.md Outdated Show resolved Hide resolved
doc/administrator/web/ubuntu/index.md Outdated Show resolved Hide resolved
doc/administrator/web/ubuntu/index.md Outdated Show resolved Hide resolved
doc/administrator/web/ubuntu/index.md Outdated Show resolved Hide resolved
doc/administrator/web/ubuntu/index.md Show resolved Hide resolved
doc/administrator/web/ubuntu/index.md Outdated Show resolved Hide resolved
doc/administrator/web/ubuntu/index.md Outdated Show resolved Hide resolved
@deepsidhu85 deepsidhu85 self-assigned this Dec 19, 2024
@deepsidhu85 deepsidhu85 added the documentation Issues relating to IRIDA's documentation label Dec 19, 2024
@deepsidhu85 deepsidhu85 marked this pull request as ready for review December 19, 2024 22:33
Copy link
Member

@JeffreyThiessen JeffreyThiessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised

@deepsidhu85 deepsidhu85 requested a review from ericenns December 20, 2024 02:40
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few comments

doc/administrator/web/index.md Outdated Show resolved Hide resolved
doc/administrator/web/index.md Show resolved Hide resolved
@ericenns ericenns merged commit 6d4696a into development Dec 20, 2024
15 checks passed
@ericenns ericenns deleted the update-installation-docs branch December 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues relating to IRIDA's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants