Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update spring-security and oauth2 implementation #1535

Conversation

ericenns
Copy link
Member

@ericenns ericenns commented Nov 13, 2024

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Update Spring Security and OAuth2 implementation to the highest minor version possible.

  • Update spring-security-oauth2-authorization-server from 0.3.1 to 0.4.5.
  • Update spring-security from 5.7.3 to 5.8.15

I used irida_linker to test the implementation.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

@ericenns ericenns requested a review from deepsidhu85 November 13, 2024 19:30
@ericenns ericenns changed the title chore(deps): Update spring-security-oauth2-authorization-server to 0.… chore(deps): Update spring-security and oauth2 implementation Nov 13, 2024
@ericenns ericenns force-pushed the dependencies/spring-security_and_spring-oauth2-authorization-server branch from 3809f06 to d25f2bb Compare November 13, 2024 19:39
@ericenns ericenns added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 13, 2024
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@deepsidhu85
Copy link
Contributor

Tested the implementation with the galaxy importer as well and it works as expected

@deepsidhu85 deepsidhu85 merged commit 4ab6575 into development Nov 15, 2024
15 checks passed
@deepsidhu85 deepsidhu85 deleted the dependencies/spring-security_and_spring-oauth2-authorization-server branch November 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants