Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set focus when opening a dropdown filter #1503

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Dec 7, 2023

Description of changes

When the filters on the project samples page open, the inputs need to be autofocused.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.
N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

@joshsadam joshsadam requested a review from deepsidhu85 December 7, 2023 15:53
@joshsadam joshsadam self-assigned this Dec 7, 2023
@joshsadam joshsadam changed the base branch from development to main December 7, 2023 17:03
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected. Thanks for updating it! Just one comment below

@deepsidhu85 deepsidhu85 merged commit 671782f into main Dec 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants