Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix flaky PipelinesPhylogenomicsPageIT #1492

Merged
merged 3 commits into from
Jun 2, 2023
Merged

test: Fix flaky PipelinesPhylogenomicsPageIT #1492

merged 3 commits into from
Jun 2, 2023

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Jun 2, 2023 •
edited
Loading

Description of changes

Fixed a flaky part of the PipelinesPhylogenomicsPageIT#testPageSetup for saving modified pipeline parameters.

  • Removed maximizing page size
  • Added scrolling to the modified alert save button
  • Cleaned up check to see if the modified alert is removed from the page.

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.

@joshsadam joshsadam self-assigned this Jun 2, 2023
@joshsadam joshsadam requested a review from ericenns June 2, 2023 15:04
ericenns
ericenns approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit db37def into development Jun 2, 2023
@ericenns ericenns deleted the fix-flaky-PipelinesPhylogenomicsPageIT branch June 2, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericenns ericenns ericenns approved these changes

Assignees

@joshsadam joshsadam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshsadam @ericenns