Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete sequence files from file storage when removed from sample #1476

Merged
merged 26 commits into from
Jun 1, 2023

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Mar 13, 2023

Description of changes

Added functionality to delete files from file storage when sequence files are removed from a sample.
Note, only files that have no analysis or sequence runs associated with it will be removed from file storage.
For now, the file is remove if it's apart of a concatenated file, as cleaning up nested concatenated files gets complicated.

Testing Instructions

  1. Test removing sequence files
  • login to IRIDA
  • create a sample under a project
  • add sequence file(s) to sample
  • verify files are on file system
  • remove sequence file(s) from sample
  • verify files are not file system
  1. Test removing sequence files during project synchronization
  • login to IRIDA
  • create a sample under a project
  • add sequence file(s) to sample
  • verify files from source project are on file system
  • initialize a project synchronization
  • verify files from target project are on file system
  • remove sequence file(s) from sample within source project
  • verify files from source project are on file system
  • synchronize the target project
  • verify files from target project are on file system

Reminder to test (nested) concatenated sequence files too.

Related issue

#1125

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

@ksierks ksierks marked this pull request as ready for review April 13, 2023 21:00
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the one comment below

@ksierks ksierks requested a review from deepsidhu85 May 15, 2023 13:51
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

@ksierks ksierks requested a review from deepsidhu85 May 15, 2023 17:10
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this is looking good, just left some comments on how to improve the code for readability.

@ksierks ksierks requested a review from ericenns May 29, 2023 18:48
@ericenns ericenns assigned ksierks and unassigned ericenns May 29, 2023
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit 9b07817 into development Jun 1, 2023
@ericenns ericenns deleted the filesystem-cleanup-delete-file-from-sample branch June 1, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants