-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete sequence files from file storage when removed from sample #1476
Delete sequence files from file storage when removed from sample #1476
Conversation
…a sequencing run before deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the one comment below
src/main/java/ca/corefacility/bioinformatics/irida/service/impl/sample/SampleServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment
src/main/java/ca/corefacility/bioinformatics/irida/service/impl/sample/SampleServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this is looking good, just left some comments on how to improve the code for readability.
...facility/bioinformatics/irida/repositories/sequencefile/SequenceConcatenationRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/service/impl/sample/SampleServiceImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description of changes
Added functionality to delete files from file storage when sequence files are removed from a sample.
Note, only files that have no analysis or sequence runs associated with it will be removed from file storage.
For now, the file is remove if it's apart of a concatenated file, as cleaning up nested concatenated files gets complicated.
Testing Instructions
Reminder to test (nested) concatenated sequence files too.
Related issue
#1125
Checklist
Things for the developer to confirm they've done before the PR should be accepted:
[ ] User documentation updated for UI or technical changes.