Add project id to project synchronization dropdown #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsadam
requested changes
Mar 10, 2023
| @@ -131,6 +131,7 @@ declare namespace IRIDA { | |||
| analysisPriority: string; | |||
| users: User[]; | |||
| analysisTemplates: string[]; // TODO (Josh - 6/7/22): What should this be | |||
| url: string; | |||
There was a problem hiding this comment.
Do we want to name this remoteUrl to directly map to the server Project model? That is what it is used for right?
There was a problem hiding this comment.
Ok, I was just doing what was easiest for me in the moment. Please see b9fae81.
joshsadam
approved these changes
Mar 11, 2023
joshsadam
deleted the
add-project-id-to-project-synchronization-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added project id to project dropdown.
Related issue
An extension of #1352
Checklist
Things for the developer to confirm they've done before the PR should be accepted:
[ ] Tests added (or description of how to test) for any new features.[ ] User documentation updated for UI or technical changes.