-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete sequence files from file system via cleanup script #1469
Conversation
…nd delete them from the filesystem
…nd delete them from the filesystem
@ksierks Hi Katherine, I see that the script cleans up files on the local file storage system but not from cloud storage (aws, azure). Are you planning on adding that in here or in another PR? |
Hi Deep. I wasn't planning on it, unless told otherwise. The file system has 10+ years worth of files. IRIDA hasn't been installed in the cloud that I know of. The intention is to only run the script once and have IRIDA cleanup files. |
Sorry about that Katherine. I missed the part in the description where the ongoing cleanup will be addressed in subsequent prs. Disregard my above comment! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few small changes.
src/main/resources/scripts/sequence-files/purge_sequence_files.py
Outdated
Show resolved
Hide resolved
src/main/resources/scripts/sequence-files/purge_sequence_files.py
Outdated
Show resolved
Hide resolved
src/main/resources/scripts/sequence-files/purge_sequence_files.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description of changes
Created a script to delete sequence files from local file system that have already been previously deleted from the database.
Previously deleted sequence files are retrieved from the audit table, because of the inconsistent way they are removed within IRIDA.
The intention is for this script to be run once to do an initial cleanup the file system. There will be subsequent PRs addressing ongoing file clean up.
Steps to test
Related issue
#1125
Checklist
Things for the developer to confirm they've done before the PR should be accepted:
[ ] Tests added (or description of how to test) for any new features.[ ] User documentation updated for UI or technical changes.