Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NCBI Export #1451

Merged
merged 10 commits into from
Jan 24, 2023
Merged

Fix NCBI Export #1451

merged 10 commits into from
Jan 24, 2023

Conversation

apetkau
Copy link
Member

@apetkau apetkau commented Jan 20, 2023

Description of changes

Fixes issue with NCBI Exports failing when picked up by background task. Changes value to model for sample.instrumentModel.model.

Related issue

Fixes #1449
Fixes #1452

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • [ ] Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

@apetkau apetkau changed the title Changed value to model Fix NCBI Export Jan 20, 2023
@apetkau
Copy link
Member Author

apetkau commented Jan 20, 2023

All the changes look good to me. Thanks.

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good me

@ericenns ericenns merged commit 773d014 into master Jan 24, 2023
@ericenns ericenns deleted the hotfix/ncbi-upload-template branch April 14, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants