Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: display synchronize new remote project url errors #1433

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Dec 9, 2022

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Updated to display error message if setting url manually for sync new remote project and the server returns an error (such as unauthorized, forbidden, not found, etc)

To test:

  1. Create a project as user A and note the project ID (will use this is step 6)
  2. Login as user B
  3. From the Projects dropdown select Synchronize Remote Project
  4. Select a project from the drop down
  5. Click the checkbox for Set URL Manually
  6. Enter in the url http://IP_ADDRESS:PORT/api/projects/PROJECT_ID
  7. Click the Create Synchronized Project button
  8. The URL input box should have an error underneath (access is denied)

accessdenied

To test not found error repeat everything and for PROJECT_ID in step 6 set the id to a project id that doesn't exist in the database. Click the Create Synchronized Project button and you should see a Resource Not Found error

resourcenotfound

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
    * [ ] User documentation updated for UI or technical changes.

@deepsidhu85 deepsidhu85 marked this pull request as ready for review December 13, 2022 19:32
@deepsidhu85 deepsidhu85 added bug UI User Interface Issue labels Dec 13, 2022
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a minor comment on the error message for FORBIDDEN.

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for fixing this bug!

@ericenns ericenns merged commit af1aafa into phac-nml:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI User Interface Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants