-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOTFIX: display synchronize new remote project url errors #1433
Merged
ericenns
merged 9 commits into
phac-nml:master
from
deepsidhu85:hotfix-display-sync-remote-project-page-errors
Dec 14, 2022
Merged
HOTFIX: display synchronize new remote project url errors #1433
ericenns
merged 9 commits into
phac-nml:master
from
deepsidhu85:hotfix-display-sync-remote-project-page-errors
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remote project and the server returns an error
ericenns
requested changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just a minor comment on the error message for FORBIDDEN.
...refacility/bioinformatics/irida/repositories/remote/resttemplate/IridaOAuthErrorHandler.java
Outdated
Show resolved
Hide resolved
ericenns
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for fixing this bug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.
Updated to display error message if setting url manually for sync new remote project and the server returns an error (such as unauthorized, forbidden, not found, etc)
To test:
Projects
dropdown selectSynchronize Remote Project
Set URL Manually
http://IP_ADDRESS:PORT/api/projects/PROJECT_ID
Create Synchronized Project
buttonTo test not found error repeat everything and for PROJECT_ID in step 6 set the id to a project id that doesn't exist in the database. Click the
Create Synchronized Project
button and you should see aResource Not Found
errorRelated issue
Link to the GitHub issue this pull request addresses using the
#issuenum
format. If it completes an issue, useFixes #issuenum
to automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted:
* [ ] User documentation updated for UI or technical changes.