Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: bug preventing usergroup manager from adding members to group linked to project #1431

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Dec 8, 2022

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Fixed bug preventing a manager of a usergroup from adding members to via a project

To test:

Before Fix (on dev branch):

  1. Create User A as user and User B as manager
  2. As User B, create user group
  3. As User A, create project and add User B as project collaborator. Also add usergroup created by User B above as collaborator
  4. As User B, try to add user A as group member to group and it should fail (the UI will not do anything but if you look in the console in intellij/vscode/etc you should see an error in the stacktrace for a nullpointer exception

After Fix (this branch):

  1. Create User A as a user and User B as manager
  2. As User B, create user group
  3. As User A, create project and add User B as project collaborator. Also, add usergroup (project settings -> user groups) created by User B above and set role as collaborator
  4. As User B, try to add user A as group member to group and it should succeed and there should be no error in the intellij/vscode/etc console.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
    * [ ] User documentation updated for UI or technical changes.

… tries to add member to a group which they are a manager for, when this group is already linked to this project
@deepsidhu85 deepsidhu85 added UI User Interface Issue back-end Issues relating to the service layer, repository, model, configuration, or database labels Dec 8, 2022
@deepsidhu85 deepsidhu85 marked this pull request as ready for review December 8, 2022 20:47
@deepsidhu85 deepsidhu85 requested a review from ericenns December 8, 2022 22:22
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is now working as expected, thanks!

@ericenns ericenns merged commit b5e7e14 into phac-nml:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Issues relating to the service layer, repository, model, configuration, or database UI User Interface Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants