Metadata uploader progress bar #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsadam
reviewed
Dec 2, 2022
| <SampleMetadataImportWizard current={2} percent={progress}> | ||
| <Text>{i18n("SampleMetadataImportReview.description")}</Text> | ||
| <SampleMetadataImportWizard current={2}> | ||
| <Text> |
There was a problem hiding this comment.
Does this cause a page shift? Could you put the in the overlay under the percentage?
There was a problem hiding this comment.
Moved the text into the spinner. Not sure if I got the css right. Please see e3f82ed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Related issue
N/A
Checklist
Things for the developer to confirm they've done before the PR should be accepted:
[ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.[ ] Tests added (or description of how to test) for any new features.[ ] User documentation updated for UI or technical changes.