Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: 22.09.3 Remote Project Syncing Issues #1410

Merged
merged 7 commits into from
Nov 10, 2022

Conversation

ericenns
Copy link
Member

@ericenns ericenns commented Nov 10, 2022

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Fixed issue with syncing remote projects, due to the following issues:

  • access_tokens acquired by refresh_token grant were missing authorities
  • invalid access_tokens would prevent remote apis from being reconnected
  • remote status having null read by due to not parsing the handling the correct authentication in setRemoteStatus method

Also fixed the following issues:

  • project owners could not delete remote projects
  • project owners could not see remote tab in settings page

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
    * [ ] Tests added (or description of how to test) for any new features.
    * [ ] User documentation updated for UI or technical changes.

@ericenns ericenns changed the base branch from development to master November 10, 2022 18:10
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

I tested syncing with 22.09.2 and got it to fail. Then the same scenario worked for 22.09.3.

@ericenns ericenns marked this pull request as ready for review November 10, 2022 19:12
@ericenns ericenns merged commit b4f1c7b into master Nov 10, 2022
@ericenns ericenns deleted the hotfix/remote-api-refresh-token-syncing branch November 10, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants