hotfix: fixed bug affecting sharing from the linelist page, and NCBI export. #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsadam
changed the title
deepsidhu85
approved these changes
Oct 21, 2022
ericenns
requested changes
Oct 21, 2022
ericenns
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Sharing is failing on the current linelist page because when the samples are stored in sessionStorage the variable name was updated but I failed to update it here. This PR fixes this and adds testing to make sure it will be caught in the future.
Also remove extra
}from cart page.Related issue
N/A
Checklist
Things for the developer to confirm they've done before the PR should be accepted:
User documentation updated for UI or technical changes.