Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed password reset for disabled accounts #1373

Merged

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Sep 27, 2022

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Fixed bug where a user with a disabled account could request a password reset and continue on into IRIDA

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
    * [ ] User documentation updated for UI or technical changes.

…rd reset, get sent an email, reset their password, and then continue into Irida (after logout they could no longer log in)
@deepsidhu85 deepsidhu85 added back-end Issues relating to the service layer, repository, model, configuration, or database security Security issues or enhancements labels Sep 27, 2022
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for fixing this bug

@ericenns ericenns merged commit 12f38f1 into phac-nml:development Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Issues relating to the service layer, repository, model, configuration, or database security Security issues or enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants