Start Galaxy Library timeout when running #1337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently, when transferring files to a Galaxy Data Library, the timeout starts when the task is added to a thread pool queue. This means the timeout before file transfer fails in IRIDA includes the time spent in the queue.
This PR changes the Galaxy Data Library transfer code to only start the timeout of data transfers when the status checking code has begun running. This makes use of a CountDownLatch.
Testing
I'm not sure if you wanted to go through testing this, but what I did is upload 59 samples and set the Galaxy upload timeout limit to 15 seconds and run two scenarios:
Related issue
Fixes #1338
Checklist
Things for the developer to confirm they've done before the PR should be accepted:
[ ] User documentation updated for UI or technical changes.