Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Galaxy Library timeout when running #1337

Conversation

apetkau
Copy link
Member

@apetkau apetkau commented Jul 4, 2022

Description of changes

Currently, when transferring files to a Galaxy Data Library, the timeout starts when the task is added to a thread pool queue. This means the timeout before file transfer fails in IRIDA includes the time spent in the queue.

This PR changes the Galaxy Data Library transfer code to only start the timeout of data transfers when the status checking code has begun running. This makes use of a CountDownLatch.

Testing

I'm not sure if you wanted to go through testing this, but what I did is upload 59 samples and set the Galaxy upload timeout limit to 15 seconds and run two scenarios:

  • Running all 59 genomes with RefSeq Masher under the old IRIDA - got a bunch of jobs erroring due to upload timeouts
  • Running all 59 genomes with RefSeq Masher with IRIDA including these changes - everything works. No errors.

Related issue

Fixes #1338

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

@apetkau apetkau marked this pull request as draft July 4, 2022 21:29
CHANGELOG.md Outdated Show resolved Hide resolved
@apetkau apetkau marked this pull request as ready for review September 8, 2022 21:53
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for adding this

@ericenns ericenns merged commit 860274d into phac-nml:development Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout when checking status of Galaxy transfers includes queue time
2 participants