Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL generation for ajax requests #1331

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Fix URL generation for ajax requests #1331

merged 2 commits into from
Jun 28, 2022

Conversation

ericenns
Copy link
Member

@ericenns ericenns commented Jun 27, 2022

Description of changes

Updated ajax urls in frontend code to use setBaseUrl. Mainly for project samples table export and download, but also cleaned up calls in other files.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
    * [ ] Tests added (or description of how to test) for any new features.
    * [ ] User documentation updated for UI or technical changes.

@ericenns ericenns changed the base branch from development to master June 27, 2022 20:28
@ericenns ericenns requested review from ksierks and joshsadam June 27, 2022 20:31
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I cannot find any more URLs missing

@ericenns ericenns marked this pull request as ready for review June 27, 2022 21:10
@ksierks ksierks merged commit 12685e1 into master Jun 28, 2022
@ksierks ksierks deleted the hotfix/ajax-js-urls branch June 28, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants