Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user routes for admin panel #1323

Merged
merged 5 commits into from
Jun 22, 2022
Merged

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Jun 20, 2022

Description of changes

Fix for rendering the user account details with the admin panel when the navigating from the admin users table.

image

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • [ ] Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

@ksierks ksierks added the UI User Interface Issue label Jun 20, 2022
@ksierks ksierks requested a review from joshsadam June 20, 2022 19:06
@ksierks ksierks marked this pull request as ready for review June 20, 2022 19:06
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of things, but most improtantly to change the anchor to a Link comonent

@ksierks ksierks requested a review from joshsadam June 21, 2022 16:22
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works good, thanks

@joshsadam joshsadam merged commit 7437587 into development Jun 22, 2022
@joshsadam joshsadam deleted the fix-user-routes-for-admin-panel branch June 22, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User Interface Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants