Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint Updates #1322

Merged
merged 9 commits into from
Jun 17, 2022
Merged

Eslint Updates #1322

merged 9 commits into from
Jun 17, 2022

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Jun 17, 2022

Description of changes

Added lint command to yarn scripts to facilitate faster and easier linting of js/ts code.
Added eslint rule to check for object and array restructuring.
Fixed some of the eslint errors.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

- warning  'meta' is defined but never used
- warning  'samples' is assigned a value but never used
-  error  Use object destructuring  prefer-destructuring
- Unnecessary escape character: \/  no-useless-escape
- 'full' is defined but never used  @typescript-eslint/no-unused-vars
- Unexpected empty object pattern  no-empty-pattern
@joshsadam joshsadam requested a review from ericenns June 17, 2022 15:57
@joshsadam joshsadam added UI User Interface Issue developer Issues effecting developers of IRIDA, but that aren't user facing labels Jun 17, 2022
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me

@ericenns ericenns merged commit b294a00 into development Jun 17, 2022
@ericenns ericenns deleted the eslint-rules branch June 17, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Issues effecting developers of IRIDA, but that aren't user facing UI User Interface Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants