Create new user account page refactor #1285

ksierks · 2022-05-24T16:31:07Z

Description of changes

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
Tests added (or description of how to test) for any new features.
User documentation updated for UI or technical changes.

joshsadam

Just a few things I see off the top.

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUserForm.jsx

joshsadam

This is coming along really well. Just a couple more things

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUserForm.jsx

src/main/webapp/resources/js/pages/admin/components/AdminUsersPage.jsx

src/main/resources/i18n/messages.properties

src/main/java/ca/corefacility/bioinformatics/irida/ria/web/users/UsersAjaxController.java

ericenns

I still need to run the branch locally, but here are my code comments. I left one comment about assert argument ordering, this applies to all asserts added in this PR.

CHANGELOG.md

src/main/resources/ca/corefacility/bioinformatics/irida/database/all-changes.xml

src/main/resources/i18n/messages.properties

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUser.jsx

...test/java/ca/corefacility/bioinformatics/irida/ria/unit/web/services/UIUsersServiceTest.java

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUser.jsx

joshsadam · 2022-06-03T17:34:58Z

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUser.jsx

+          loading: submitting,
+          onClick: form.submit,
+        }}
+        onCancel={() => setVisibility(false)}


You close the modal you need to call form reset

Please see 3067d5f.

pom.xml

joshsadam

I think this is good to go now, thanks @ksierks

deepsidhu85

Last few things. Otherwise it's good to go

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUser.jsx

ksierks added 5 commits May 19, 2022 13:40

starting modal that displays create new user form

fa36308

refresh users table after creating a new user

4d942a3

using mailConfigured form settingsApi

12ca181

using scrollable modal

890fdcf

displaying set password when activation email not set

fa97333

joshsadam requested changes May 24, 2022

View reviewed changes

ksierks added 5 commits May 24, 2022 13:10

making modal taller

f66a320

removing confirm password

b6a009d

adding min length client side validation

9038dd2

adding form default values

cac92d4

making phone number optional

5040590

ksierks requested a review from joshsadam May 24, 2022 20:37

making locale and role required for both create and edit pages

8324a48

joshsadam requested changes May 25, 2022

View reviewed changes

ksierks added 9 commits May 25, 2022 09:54

starting to remove unused logic

15cc683

using modal button to submit form

43fb863

focusing on username on open modal

513a752

auto check email user activation if email configured

d669142

adding loading to submit button

c2e0e74

fixing AdminUsersPage.jsx comments

60881d5

returning AjaxFormError in ajax controller

73fe1ad

Merge branch 'development' into create-new-user-account-page-refactor

fdc379e

fixing merge mistake

63fbb60

ksierks requested a review from joshsadam May 25, 2022 20:17

ksierks added 6 commits May 26, 2022 09:15

removing more unused code

cd58340

handling mail failure

b9228d6

handling mail failure

4e9830a

updating javadocs

4de4fbf

fixing uiservice testing

42c1ab0

fixing mail failure

a557bcf

ksierks requested a review from ericenns June 1, 2022 18:05

ericenns requested changes Jun 1, 2022

View reviewed changes

ksierks added 3 commits June 1, 2022 13:38

updating changelog

7574ba4

renaming change set folder 22.09 to unreleased

c40a2b8

fixing assertions

9109cf9

ksierks assigned deepsidhu85 Jun 1, 2022

ksierks added 7 commits June 1, 2022 21:47

consolidating password validation

51a57e9

fixing test

c5cab1f

starting to remove manager access from user details page

22e24d0

fix test

7ec2339

creating PasswordPolicyAlert component

06c958c

fixing validation when submitting empty field

3fa8b73

hiding mailfailure after user creation

6313ff4

ericenns approved these changes Jun 3, 2022

View reviewed changes

joshsadam reviewed Jun 3, 2022

View reviewed changes

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUser.jsx Outdated Show resolved Hide resolved

ksierks added 2 commits June 3, 2022 10:30

fixing tests again

d0c2b36

using modal buttons

07095c6

joshsadam reviewed Jun 3, 2022

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

clearing form fields on cancel

3067d5f

ksierks requested a review from joshsadam June 6, 2022 13:53

joshsadam approved these changes Jun 6, 2022

View reviewed changes

deepsidhu85 requested changes Jun 6, 2022

View reviewed changes

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUser.jsx Show resolved Hide resolved

src/main/webapp/resources/js/pages/admin/components/user/CreateNewUser.jsx Show resolved Hide resolved

consolidating user validation rules

76b939a

ksierks requested a review from deepsidhu85 June 7, 2022 03:40

deepsidhu85 approved these changes Jun 7, 2022

View reviewed changes

joshsadam merged commit a37317b into development Jun 7, 2022

joshsadam deleted the create-new-user-account-page-refactor branch June 7, 2022 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create new user account page refactor #1285

Create new user account page refactor #1285

ksierks commented May 24, 2022 •

edited

Loading

joshsadam left a comment

joshsadam left a comment

ericenns left a comment

joshsadam Jun 3, 2022

ksierks Jun 6, 2022

joshsadam left a comment

deepsidhu85 left a comment

Create new user account page refactor #1285

Create new user account page refactor #1285

Conversation

ksierks commented May 24, 2022 • edited Loading

Description of changes

Related issue

Checklist

joshsadam left a comment

Choose a reason for hiding this comment

joshsadam left a comment

Choose a reason for hiding this comment

ericenns left a comment

Choose a reason for hiding this comment

joshsadam Jun 3, 2022

Choose a reason for hiding this comment

ksierks Jun 6, 2022

Choose a reason for hiding this comment

joshsadam left a comment

Choose a reason for hiding this comment

deepsidhu85 left a comment

Choose a reason for hiding this comment

ksierks commented May 24, 2022 •

edited

Loading