-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22.03 Performance Release #1211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
907f6e9
to
fe73f5a
Compare
…or use in ProjectEventHandler.
…ove explicit save calls to Project when updating the modifiedDate when handling a ProjectEvent.
… previous implementation had deadlock issues.
931db5f
to
87cd7e0
Compare
…d calls, and update Sample modifiedDate through custom repository method for speed.
73fc4c2
to
943f527
Compare
…ds to use lightweight entities and a read only repository for performance.
…to the server to get the command string.
…data rest api and linelist entries controllers.
…fter batch load refactor.
…e than when initializing progress bar for fetching linelist rows.
16ec4fe
to
5259462
Compare
…mplate response for linelist page.
…e in LineListController and fix issue with sending metadata templates to linelist.
…sues' into fix-project-event-scalability-issues
…mment in ProjectRepositoryCustom.java
deepsidhu85
requested changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking reaallyy good! Great work @ericenns @joshsadam. Just a few small things below
...refacility/bioinformatics/irida/database/changesets/22.03/add-sampleName-index-to-sample.xml
Show resolved
Hide resolved
...refacility/bioinformatics/irida/database/changesets/22.03/add-sampleName-index-to-sample.xml
Show resolved
Hide resolved
src/main/webapp/resources/js/pages/projects/linelist/components/Table/LoadingOverlay.jsx
Outdated
Show resolved
Hide resolved
src/main/webapp/resources/js/pages/projects/linelist/components/Table/LoadingOverlay.jsx
Outdated
Show resolved
Hide resolved
src/main/webapp/resources/js/pages/projects/linelist/components/Table/Table.jsx
Outdated
Show resolved
Hide resolved
src/main/webapp/resources/js/pages/projects/samples/linker/Linker.jsx
Outdated
Show resolved
Hide resolved
…sues' into fix-project-event-scalability-issues
deepsidhu85
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Thanks guys! That's all from me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR started off as just fixing a scalability issue in ProjectEventHandler and has since transformed into a performance release that enables Users to have massive projects (i.e. >=100,000 samples).
The original Scalability issue that I identified was that as the number of Samples increased in a Project, certain operations would increase in time. An example is as follows:
send_sample
);Here are the results of the test:
Summary of Changes:
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenum
format. If it completes an issue, useFixes #issuenum
to automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted:
* [ ] User documentation updated for UI or technical changes.