Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Simplify Samples services samples_count validations #874

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

ericenns
Copy link
Member

What does this PR do and why?

Describe in detail what your merge request does and why.

Updated service tests for samples services that update samples_count, to make it easier to read and ensure that count if updating correctly.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@ericenns ericenns self-assigned this Dec 18, 2024

This comment has been minimized.

Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

Code Metrics Report

Coverage Test Execution Time
92.7% 10m1s

Reported by octocov

Copy link
Contributor

@malchua malchua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChrisHuynh333 ChrisHuynh333 merged commit 7ccf8ca into main Dec 18, 2024
4 checks passed
@ChrisHuynh333 ChrisHuynh333 deleted the samples_count-test-updates branch December 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants