-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samples Table: Determine query type #873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChrisHuynh333
changed the title
Samples Index: Determine query type
Samples Table: Determine query type
Dec 18, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Code coverage of files in pull request scope (95.2%)
Reported by octocov |
ericenns
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
This PR adds the framework to determine whether the samples table loads samples via
ransack
(simple default page load, simple sorting/filtering, etc.) orsearchkick
(advanced queries).In addition, samples
select
will also usequery.advanced_query
to determine ifransack
orsearchkick
should be used. With large sample sets,ransack
is much quicker (see screencasts below).Note: logic determining what is an
advanced_query
, in order to useransack
orsearchkick
, has not been determined, and will be implemented when more advanced querying within IRIDA Next is ready to be added.Screenshots or screen recordings
Select all differences:
Ransack:
Screencast from 2024-12-18 10:26:39 AM.webm
Searchkick:
Screencast from 2024-12-18 10:27:14 AM.webm
How to set up and validate locally
Test the functionality of both project and group's samples table and verify they function as expected.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.